Bug 33786

Summary: [Qt] Fix qmake warning with qmake in Qt for Symbian
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kenneth, laszlo.gombos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Simon Hausmann
Reported 2010-01-18 00:35:31 PST
[Qt] Fix qmake warning with qmake in Qt for Symbian
Attachments
Patch (1.10 KB, patch)
2010-01-18 00:36 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2010-01-18 00:36:49 PST
Created attachment 46795 [details] Patch
Simon Hausmann
Comment 2 2010-01-18 00:37:31 PST
(In reply to comment #1) > Created an attachment (id=46795) [details] > Patch Note that this patch will break the build on Symbian with Qt versions earlier than Qt 4.6.0.
Simon Hausmann
Comment 3 2010-01-18 00:38:38 PST
Comment on attachment 46795 [details] Patch Laszlo, are you okay with this change?
Kenneth Rohde Christiansen
Comment 4 2010-01-18 00:43:39 PST
Sorry, awaiting Laszlo's input.
Kenneth Rohde Christiansen
Comment 5 2010-01-18 00:45:56 PST
What about doing this for Qt 4.6 only? If that is possible.
Simon Hausmann
Comment 6 2010-01-18 01:17:19 PST
(In reply to comment #5) > What about doing this for Qt 4.6 only? If that is possible. I just want to check if it would cause problems with their environment and if yes then we simply wait. It's just a warning fix and a small good cleanup after all.
Laszlo Gombos
Comment 7 2010-01-18 20:43:27 PST
Comment on attachment 46795 [details] Patch Looks good to me as well, but have not had a chance to try it - for that we need more time. I'm OK with landing it now (but only for trunk). I think for the Symbian port Qt version 4.6 is probably a minimal dependency anyway.
WebKit Commit Bot
Comment 8 2010-01-19 14:14:37 PST
Comment on attachment 46795 [details] Patch Clearing flags on attachment: 46795 Committed r53493: <http://trac.webkit.org/changeset/53493>
WebKit Commit Bot
Comment 9 2010-01-19 14:14:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.