Bug 33786 – [Qt] Fix qmake warning with qmake in Qt for Symbian

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Hausmann]

[Qt] Fix qmake warning with qmake in Qt for Symbian

[Simon Hausmann]

Created attachment 46795 [details]
Patch

[Simon Hausmann]

(In reply to comment #1)
> Created an attachment (id=46795) [details]
> Patch

Note that this patch will break the build on Symbian with Qt versions earlier than Qt 4.6.0.

[Simon Hausmann]

Comment on attachment 46795 [details]
Patch

Laszlo, are you okay with this change?

[Kenneth Rohde Christiansen]

Sorry, awaiting Laszlo's input.

[Kenneth Rohde Christiansen]

What about doing this for Qt 4.6 only? If that is possible.

[Simon Hausmann]

(In reply to comment #5)
> What about doing this for Qt 4.6 only? If that is possible.

I just want to check if it would cause problems with their environment and if yes then we simply wait. It's just a warning fix and a small good cleanup after all.

[Laszlo Gombos]

Comment on attachment 46795 [details]
Patch

Looks good to me as well, but have not had a chance to try it - for that we need more time. I'm OK with landing it now (but only for trunk).

I think for the Symbian port Qt version 4.6 is probably a minimal dependency anyway.

[WebKit Commit Bot]

Comment on attachment 46795 [details]
Patch

Clearing flags on attachment: 46795

Committed r53493: <http://trac.webkit.org/changeset/53493>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.