Bug 33786 - [Qt] Fix qmake warning with qmake in Qt for Symbian
Summary: [Qt] Fix qmake warning with qmake in Qt for Symbian
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-18 00:35 PST by Simon Hausmann
Modified: 2010-01-19 14:14 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.10 KB, patch)
2010-01-18 00:36 PST, Simon Hausmann
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2010-01-18 00:35:31 PST
[Qt] Fix qmake warning with qmake in Qt for Symbian
Comment 1 Simon Hausmann 2010-01-18 00:36:49 PST
Created attachment 46795 [details]
Patch
Comment 2 Simon Hausmann 2010-01-18 00:37:31 PST
(In reply to comment #1)
> Created an attachment (id=46795) [details]
> Patch

Note that this patch will break the build on Symbian with Qt versions earlier than Qt 4.6.0.
Comment 3 Simon Hausmann 2010-01-18 00:38:38 PST
Comment on attachment 46795 [details]
Patch

Laszlo, are you okay with this change?
Comment 4 Kenneth Rohde Christiansen 2010-01-18 00:43:39 PST
Sorry, awaiting Laszlo's input.
Comment 5 Kenneth Rohde Christiansen 2010-01-18 00:45:56 PST
What about doing this for Qt 4.6 only? If that is possible.
Comment 6 Simon Hausmann 2010-01-18 01:17:19 PST
(In reply to comment #5)
> What about doing this for Qt 4.6 only? If that is possible.

I just want to check if it would cause problems with their environment and if yes then we simply wait. It's just a warning fix and a small good cleanup after all.
Comment 7 Laszlo Gombos 2010-01-18 20:43:27 PST
Comment on attachment 46795 [details]
Patch

Looks good to me as well, but have not had a chance to try it - for that we need more time. I'm OK with landing it now (but only for trunk).

I think for the Symbian port Qt version 4.6 is probably a minimal dependency anyway.
Comment 8 WebKit Commit Bot 2010-01-19 14:14:37 PST
Comment on attachment 46795 [details]
Patch

Clearing flags on attachment: 46795

Committed r53493: <http://trac.webkit.org/changeset/53493>
Comment 9 WebKit Commit Bot 2010-01-19 14:14:43 PST
All reviewed patches have been landed.  Closing bug.