Bug 33780

Summary:

Build WebKitGtk on OpenSolaris with Sun Studio 12 using apache STL(stdcxx4)

Product:

WebKit

Reporter:

Simon <yuntong.jin>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Major

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Other

Attachments:

Description	Flags
add sun cc support in WFT	yuntong.jin: review-
explicit KURL to Sting	yuntong.jin: review-
delete illegal option for SUN CC	none
Add Solaris platform support	none
support-stdcxx4 instead of Cstd that come with SS12	yuntong.jin: review-
explicit const char* in SVG	none

Simon

Reported 2010-01-17 19:04:13 PST

STL library(Cstd) come with SS12 is too out for WTF and STLport come with SS12 is not SUN recommend. Since apache STL(stdcxx4) is been integrated in OpenSolaris since nv124,i manage to build WebKitGtk on OpenSolaris successfully with some patches, those patch also work on linux with gcc. those patches are based on webkitgtk 1.1.17 release. Also noticed some work has been done in webkitgt on Solaris 10 with SS12 24932:WebKit compilation support in Solaris 10 with Sun Studio 12 (CC 5.9)

Attachments
add sun cc support in WFT (1.06 KB, patch) 2010-01-17 19:17 PST, Simon	yuntong.jin: review-	Details Formatted Diff Diff
explicit KURL to Sting (3.94 KB, patch) 2010-01-17 19:19 PST, Simon	yuntong.jin: review-	Details Formatted Diff Diff
delete illegal option for SUN CC (5.86 KB, patch) 2010-01-17 19:20 PST, Simon	no flags	Details Formatted Diff Diff
Add Solaris platform support (1.71 KB, patch) 2010-01-17 19:22 PST, Simon	no flags	Details Formatted Diff Diff
support-stdcxx4 instead of Cstd that come with SS12 (663 bytes, patch) 2010-01-17 19:28 PST, Simon	yuntong.jin: review-	Details Formatted Diff Diff
*explicit const char in SVG** (105.17 KB, patch) 2010-01-17 19:31 PST, Simon	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Simon

Comment 1 2010-01-17 19:17:57 PST

Created attachment 46777 [details] add sun cc support in WFT "./JavaScriptCore/wtf/Vector.h", line 48: Error: #error WTF_ALIGN macros need alignment control.. make[1]: *** [WebKit/gtk/WebCoreSupport/libwebkit_1_0_la-ChromeClientGtk.lo] Error 1 make[1]: Leaving directory `/export/home/simon/webkitwork/17work/webkit-1.1.17

Simon

Comment 2 2010-01-17 19:19:38 PST

Created attachment 46778 [details] explicit KURL to Sting "./WebCore/loader/DocumentLoader.h", line 166: Error: Different types for "?:" (WebCore::String and WebCore::KURL). ./WebCore/platform/network/ResourceHandleInternal.h", line 50: Error: The name Frame is ambiguous, Frame and WebCore::Frame.

Simon

Comment 3 2010-01-17 19:20:18 PST

Created attachment 46779 [details] delete illegal option for SUN CC cc: illegal option -Wall delete illegal option for SUN CC

Simon

Comment 4 2010-01-17 19:22:57 PST

Created attachment 46780 [details] Add Solaris platform support add Solaris platform support

Simon

Comment 5 2010-01-17 19:28:06 PST

Created attachment 46781 [details] support-stdcxx4 instead of Cstd that come with SS12 it's actually better use solaris_use_no-cstd instead of solaris_use_stlport4 here.;

Simon

Comment 6 2010-01-17 19:31:50 PST

Created attachment 46782 [details] explicit const char* in SVG

Alexey Proskuryakov

Comment 7 2010-06-12 16:46:46 PDT

This patch has been overlooked, because it isn't marked for review. Please see <http://webkit.org/coding/contributing.html> for more information. I don't see it explained why these type casts are needed. Anyway, WebKit coding style is to use C++ style casts, so (const char *) isn't OK.

Note You need to log in before you can comment on or make changes to this bug.