Bug 33757 – Reduce duplication in run-webkit-httpd and run-webkit-tests

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Holger Freyther]

Created attachment 46737 [details]
Patch

Currently both scripts have code to figure out the name of the apache2
executable and which configuration file to use for the server. I'm currently
in the process of making run-iexploder-tests work for everyone else and
would have to copy the code again.
Instead of copying it to the iexploder-tests script I'm copying it to
webkitdirs.pm and make both existing scripts use the new method to
figure out httpdPath and httpdConfiguration.

[Darin Adler]

Comment on attachment 46737 [details]
Patch

I don't feel great about this -- the webktidirs.pm file is getting bigger and bigger with no clear concept of what it does and does not do!

r=me

[Holger Freyther]

(In reply to comment #1)
> (From update of attachment 46737 [details])
> I don't feel great about this -- the webktidirs.pm file is getting bigger and
> bigger with no clear concept of what it does and does not do!

Well, then let us get the concept? Should I write to webkit-dev about it? I think python vs. perl is also playing a role here?

[Eric Seidel (no email)]

Attachment 46737 [details] was posted by a committer and has review+, assigning to Holger Freyther for commit.

[Alexey Proskuryakov]

We also have WebKitTools/Scripts/webkitperl/httpd.pm now - could it be a better place to move this code to?

[Holger Freyther]

(In reply to comment #4)
> We also have WebKitTools/Scripts/webkitperl/httpd.pm now - could it be a better
> place to move this code to?

I think most of this is deprecated anyway. I will close this now and come up with a patch for run-iexploder-tests.