Bug 33727 – 'make dist' misses some files in the nightly build

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Danilo Šegan]

I tried building webkit r53331 from svn (as a package for Ubuntu) and ran into several files missing from 'make dist'. I'll attach a full patch once webkit finishes building, but here's what I found missing so far:

--- WebCore/GNUmakefile.am	(revision 53331)
+	WebCore/html/canvas/CanvasContextAttributes.h \
+	WebCore/platform/graphics/GraphicsLayer.h \
+	WebCore/platform/graphics/TypesettingFeatures.h \
+	WebCore/plugins/PluginWidget.h \

FWIW, I've also hit http://www.mail-archive.com/[e-mail]/msg02270.html but I am solving that with a modified "mydist" rule along the lines of

+dist.txt:
+	FILES_TO_DIST=$(words $(DISTFILES))
+	echo "$(wordlist 1,2000,$(DISTFILES))" > dist.txt
+	echo "$(wordlist 2001,4000,$(DISTFILES))" >> dist.txt

[Danilo Šegan]

Created attachment 46693 [details]
First .h files missing from dist rules

I will "override" this patch if I find more instances.

[Danilo Šegan]

Ok, this are all I have found missing, so the above patch should be complete.

[Alexey Proskuryakov]

This patch has been overlooked, because it isn't marked for review. Please see <http://webkit.org/coding/contributing.html> for more information.

[Martin Robinson]

This was probably fixed long ago and 'make dist' has totally changed with the new build system.