|Summary:||Cleanup: Fix style errors exposed by the patch for bug #33498|
|Product:||WebKit||Reporter:||Daniel Bates <dbates>|
|Component:||WebCore Misc.||Assignee:||Daniel Bates <dbates>|
|Severity:||Normal||CC:||bdakin, commit-queue, eric, krit, ossy, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description Daniel Bates 2010-01-15 11:03:02 PST
We should fix the style errors found by the style bot with respect to the patch for bug #33498.
Comment 1 Daniel Bates 2010-01-15 11:07:40 PST
Created attachment 46691 [details] Patch Moreover, this fixes all the style errors found by check-webkit-style except the use of an underline in the variable name _niflags. We should fix this in a second run through for all the other variables names that contain an underline because there are many. for some reason, check-webkit-style does not catch all the other variables with underlines in their names, see bug #33724.
Comment 2 WebKit Review Bot 2010-01-15 11:10:02 PST
Attachment 46691 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/rendering/style/SVGRenderStyle.h:167: _niflags is incorrectly named. Don't use underscores in your identifier names. [readability/naming]  Total errors found: 1
Comment 3 Eric Seidel (no email) 2010-01-15 11:32:55 PST
Comment on attachment 46691 [details] Patch Assuming this is just style cleanup, then r=me.
Comment 4 Adam Barth 2010-01-18 01:49:22 PST
Comment on attachment 46691 [details] Patch Seems safe to commit queue.
Comment 5 WebKit Commit Bot 2010-01-18 05:33:49 PST
Comment on attachment 46691 [details] Patch Clearing flags on attachment: 46691 Committed r53402: <http://trac.webkit.org/changeset/53402>
Comment 6 WebKit Commit Bot 2010-01-18 05:33:56 PST
All reviewed patches have been landed. Closing bug.