Bug 33705

Summary: UStringImpl::create() should use internal storage
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch oliver: review+

Description Gavin Barraclough 2010-01-14 23:35:55 PST 
When creating a UStringImpl copying of a UChar*, we can use an internal buffer, by calling UStringImpl::tryCreateUninitialized().
Comment 1 Gavin Barraclough 2010-01-14 23:37:40 PST 
Created attachment 46644 [details]
The patch

~0.5% progression on SunSpider
Comment 2 Oliver Hunt 2010-01-14 23:40:41 PST 
Comment on attachment 46644 [details]
The patch

r=me, you should remove "Need a short description and bug URL (OOPS!)" from the changelog however :)
Comment 3 Gavin Barraclough 2010-01-14 23:48:19 PST 
Committed revision 53323.