Summary: | [Android] Android requires Geolocation::suspend/resume to be public | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Steve Block <steveblock> | ||||||||
Component: | WebCore Misc. | Assignee: | Steve Block <steveblock> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | android-webkit-unforking, commit-queue, eric, sam, steveblock | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Android | ||||||||||
OS: | Android | ||||||||||
Attachments: |
|
Description
Steve Block
2010-01-14 09:52:51 PST
Created attachment 46582 [details] Patch 1 for Bug 33679 Created attachment 46584 [details] Patch 2 for Bug 33679 Created attachment 46585 [details] Patch 3 for Bug 33679 Comment on attachment 46585 [details] Patch 3 for Bug 33679 Why don't the other ports need these public? Who else works on Geolocation (outside of Android) who should be CC'd on geolocation bugs? (In reply to comment #4) > (From update of attachment 46585 [details]) > Why don't the other ports need these public? I'm not sure, but I don't think that any other ports have complete Geolocation implementations fully upstreamed to WebKit. Android uses these methods to disable the GPS when a page using Geolocation is not in the foreground, to save battery. > Who else works on Geolocation (outside of Android) who should be CC'd on > geolocation bugs? Nobody. Sam (already cc'ed) wrote the change in Bug 32499 which introduced this breakage, and said he'd put back the suspend/resume methods. Comment on attachment 46585 [details] Patch 3 for Bug 33679 OK. Comment on attachment 46585 [details] Patch 3 for Bug 33679 Clearing flags on attachment: 46585 Committed r53342: <http://trac.webkit.org/changeset/53342> All reviewed patches have been landed. Closing bug. |