Bug 33679

Summary: [Android] Android requires Geolocation::suspend/resume to be public
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking, commit-queue, eric, sam, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Attachments:
Description Flags
Patch 1 for Bug 33679
none
Patch 2 for Bug 33679
none
Patch 3 for Bug 33679 none

Steve Block
Reported 2010-01-14 09:52:51 PST
Android requires Geolocation::suspend/resume to be public. These were made private in https://bugs.webkit.org/show_bug.cgi?id=32499
Attachments
Patch 1 for Bug 33679 (1.58 KB, patch)
2010-01-14 10:04 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Patch 2 for Bug 33679 (2.29 KB, patch)
2010-01-14 10:25 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Patch 3 for Bug 33679 (2.38 KB, patch)
2010-01-14 10:29 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2010-01-14 10:04:49 PST
Created attachment 46582 [details] Patch 1 for Bug 33679
Steve Block
Comment 2 2010-01-14 10:25:08 PST
Created attachment 46584 [details] Patch 2 for Bug 33679
Steve Block
Comment 3 2010-01-14 10:29:51 PST
Created attachment 46585 [details] Patch 3 for Bug 33679
Eric Seidel (no email)
Comment 4 2010-01-14 17:19:17 PST
Comment on attachment 46585 [details] Patch 3 for Bug 33679 Why don't the other ports need these public?
Eric Seidel (no email)
Comment 5 2010-01-14 17:19:44 PST
Who else works on Geolocation (outside of Android) who should be CC'd on geolocation bugs?
Steve Block
Comment 6 2010-01-15 02:19:05 PST
(In reply to comment #4) > (From update of attachment 46585 [details]) > Why don't the other ports need these public? I'm not sure, but I don't think that any other ports have complete Geolocation implementations fully upstreamed to WebKit. Android uses these methods to disable the GPS when a page using Geolocation is not in the foreground, to save battery. > Who else works on Geolocation (outside of Android) who should be CC'd on > geolocation bugs? Nobody. Sam (already cc'ed) wrote the change in Bug 32499 which introduced this breakage, and said he'd put back the suspend/resume methods.
Eric Seidel (no email)
Comment 7 2010-01-15 10:07:41 PST
Comment on attachment 46585 [details] Patch 3 for Bug 33679 OK.
WebKit Commit Bot
Comment 8 2010-01-15 12:53:21 PST
Comment on attachment 46585 [details] Patch 3 for Bug 33679 Clearing flags on attachment: 46585 Committed r53342: <http://trac.webkit.org/changeset/53342>
WebKit Commit Bot
Comment 9 2010-01-15 12:53:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.