Bug 33677

Summary: [V8] Standardize V8 generated and custom bindings on a single toNative() conversion method
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebCore Misc.Assignee: Nate Chapin <japhet>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 32563    
Attachments:
Description Flags
patch
dglazkov: review+
the rest
japhet: commit-queue-
the rest - compile fixed dglazkov: review+, japhet: commit-queue-

Description Nate Chapin 2010-01-14 09:38:38 PST 
Currently, we've got multiple functions doing essentially the same work.  Make it stop.
Comment 1 Nate Chapin 2010-01-14 10:16:58 PST 
Created attachment 46583 [details]
patch
Comment 2 Dimitri Glazkov (Google) 2010-01-14 10:25:17 PST 
Comment on attachment 46583 [details]
patch

This is freaky-good. Nate++.
Comment 3 Nate Chapin 2010-01-14 12:10:38 PST 
Comment on attachment 46583 [details]
patch

http://trac.webkit.org/changeset/53271
Comment 4 Nate Chapin 2010-01-14 12:11:10 PST 
Created attachment 46593 [details]
the rest

This will break the chromium canaries.
Comment 5 WebKit Review Bot 2010-01-14 12:15:57 PST 
Attachment 46593 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/187587
Comment 6 Nate Chapin 2010-01-14 12:24:08 PST 
Created attachment 46595 [details]
the rest - compile fixed

Removing a function that I forgot to update because it isn't called anywhere.
Comment 7 Dimitri Glazkov (Google) 2010-01-14 13:48:09 PST 
Comment on attachment 46595 [details]
the rest - compile fixed

Even betterrer.
Comment 8 Nate Chapin 2010-01-14 14:09:36 PST 
http://trac.webkit.org/changeset/53290