Bug 33663

Summary: check-webkit-style underscore check should be disabled for Qt methods starting with qt_
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cjerdonek, commit-queue, eric, hamaji, levin, robert
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch none

Description Kenneth Rohde Christiansen 2010-01-14 02:57:39 PST
check-webkit-style underscore check should be disabled for Qt methods starting with qt_, as Qt uses that for private API, such as for the DRT only.
Comment 1 Eric Seidel (no email) 2010-01-14 03:09:06 PST
We could even restrict this allowance to the qt directory, although allowing qt_ anywhere is really not a problem either.
Comment 2 Kenneth Rohde Christiansen 2010-01-14 03:32:08 PST
I would still like the underscore check so make sure that the patches we receive do not use names like _privateMessage() etc.
Comment 3 Adam Barth 2010-01-17 15:46:45 PST
Created attachment 46763 [details]
Patch
Comment 4 Adam Barth 2010-01-17 16:06:41 PST
*** Bug 33116 has been marked as a duplicate of this bug. ***
Comment 5 Shinichiro Hamaji 2010-01-17 17:35:09 PST
Comment on attachment 46763 [details]
Patch

Thanks for fixing this issue!
Comment 6 WebKit Commit Bot 2010-01-17 18:06:16 PST
Comment on attachment 46763 [details]
Patch

Clearing flags on attachment: 46763

Committed r53381: <http://trac.webkit.org/changeset/53381>
Comment 7 WebKit Commit Bot 2010-01-17 18:06:25 PST
All reviewed patches have been landed.  Closing bug.