Summary: | check-webkit-style underscore check should be disabled for Qt methods starting with qt_ | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Rohde Christiansen <kenneth> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, cjerdonek, commit-queue, eric, hamaji, levin, robert | ||||
Priority: | P3 | Keywords: | Qt | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Kenneth Rohde Christiansen
2010-01-14 02:57:39 PST
We could even restrict this allowance to the qt directory, although allowing qt_ anywhere is really not a problem either. I would still like the underscore check so make sure that the patches we receive do not use names like _privateMessage() etc. Created attachment 46763 [details]
Patch
*** Bug 33116 has been marked as a duplicate of this bug. *** Comment on attachment 46763 [details]
Patch
Thanks for fixing this issue!
Comment on attachment 46763 [details] Patch Clearing flags on attachment: 46763 Committed r53381: <http://trac.webkit.org/changeset/53381> All reviewed patches have been landed. Closing bug. |