Summary: | [Chromium] Fix a bug that a selected word is not recognized as a spell-check source. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, fishd, yaar | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Kent Tamura
2010-01-14 01:50:58 PST
Created attachment 46549 [details]
Patch
The current implementation of isASingleWord() means: "true if the text has no characters." You should CC people who you think could best review this. I'm not familiar with this code. isASingleWord() implementation was changed during upstreaming WebKit API. The last revision in Chromium repository seems to have a correct implementation. http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/context_menu_client_impl.cc?annotate=29390&pathrev=29813 (In reply to comment #4) > isASingleWord() implementation was changed during upstreaming WebKit API. > The last revision in Chromium repository seems to have a correct > implementation. > > http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/context_menu_client_impl.cc?annotate=29390&pathrev=29813 Correction: It was changed by Chromium r29814, http://src.chromium.org/viewvc/chrome?view=rev&revision=29814, Moving it from webkit/glue/ to webkit/api/src. Comment on attachment 46549 [details]
Patch
I don't know this code super well, but assuming this is just up-streaming a downstream fix (that was presumably reviewed): r=me
Landed as r54119 <http://trac.webkit.org/changeset/54119> |