Bug 33650

Summary: REGRESSION (r53004): Page layout is broken at http://www.redfin.com listings
Product: WebKit Reporter: Adele Peterson <adele>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hyatt, yuzo
Priority: P1 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
reduction
none
Skip error after invalid blocks in function argument.
none
Skip an error after invalid blocks in a CSS expression.
hyatt: review-, hyatt: commit-queue-
Skip an error after invalid blocks in a CSS expression. none

Description Adele Peterson 2010-01-13 22:02:05 PST 
Created attachment 46539 [details]
reduction

Load any redfin.com listing page, like: http://www.redfin.com/CA/San-Jose/3070-Crystal-Creek-Dr-95133/home/1571004

The CSS doesn't parse correctly, and the page layout is seriously broken.

Introduced in http://trac.webkit.org/changeset/53004

<rdar://problem/7540863>
Comment 1 Yuzo Fujishima 2010-01-17 22:38:43 PST 
Created attachment 46788 [details]
Skip error after invalid blocks in function argument.
Comment 2 Yuzo Fujishima 2010-01-17 22:43:48 PST 
Created attachment 46789 [details]
Skip an error after invalid blocks in a CSS expression.
Comment 3 Yuzo Fujishima 2010-01-17 22:45:01 PST 
Hi,

Sorry for the regression. Can someone review the patch?

Yuzo
Comment 4 Adele Peterson 2010-01-18 10:29:35 PST 
CCing Hyatt to see if he'd like to review
Comment 5 Dave Hyatt 2010-01-18 12:02:51 PST 
Comment on attachment 46789 [details]
Skip an error after invalid blocks in a CSS expression.

Your test case is wrong.  You meant to use test4 as the id.
Comment 6 Yuzo Fujishima 2010-01-18 17:00:54 PST 
Created attachment 46865 [details]
Skip an error after invalid blocks in a CSS expression.
Comment 7 Yuzo Fujishima 2010-01-18 17:02:37 PST 
Thank you for the review.

Fixed the test id. Can you take another look?

Yuzo
Comment 8 WebKit Commit Bot 2010-01-18 18:53:22 PST 
Comment on attachment 46865 [details]
Skip an error after invalid blocks in a CSS expression.

Clearing flags on attachment: 46865

Committed r53448: <http://trac.webkit.org/changeset/53448>
Comment 9 WebKit Commit Bot 2010-01-18 18:53:28 PST 
All reviewed patches have been landed.  Closing bug.