Bug 33629

Summary:

Fix shadow drawing to do the correct computations using the base coordinate space

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Layout and Rendering

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mitz

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

OS X 10.5

Attachments:

Description	Flags
Step 1: Rename patch	none
Patch	mitz: review+

Description Simon Fraser (smfr) 2010-01-13 15:45:07 PST

In Core Graphics, shadow offsets should be specified in the base coordinate system (which is the coordinate system of a newly created CGContext before any user space transforms have been applied). We need to do the right math to fix shadow drawing accordingly.

Comment 1 Simon Fraser (smfr) 2010-01-13 15:45:38 PST

<rdar://problem/7532544>

Comment 2 Simon Fraser (smfr) 2010-01-13 15:58:39 PST

Created attachment 46516 [details]
Step 1: Rename patch

Comment 3 Simon Fraser (smfr) 2010-01-13 18:07:25 PST

Created attachment 46532 [details]
Patch

Comment 4 Simon Fraser (smfr) 2010-01-13 18:08:24 PST

First patch was committed in
http://trac.webkit.org/changeset/53211

Comment 5 Simon Fraser (smfr) 2010-01-13 20:44:46 PST

http://trac.webkit.org/changeset/53235