Bug 33628

Summary:

LayoutTests/storage/quota-tracking.html needs to be cleaned up

Product:

WebKit

Reporter:

Dumitru Daniliuc <dumi>

Component:

New Bugs

Assignee:

Dumitru Daniliuc <dumi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, michaeln

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	dglazkov: review+, dumi: commit-queue-

Description Dumitru Daniliuc 2010-01-13 15:40:48 PST

Things that need to be cleaned up in quota-tracking.html:
-- Remove all trailing whitespaces
-- Refactor errorFunction(). Right now, it takes two parameters (tx, error) and is used as the error function for both executeSql() and transaction(). The problem is that transaction()'s error callback uses only one parameter. So if a transaction fails, the error gets assigned to the 'tx' parameter, and the 'error' parameter is left undefined; this leads to an exception when errorFunction() tries to log 'error.message'.

Comment 1 Dumitru Daniliuc 2010-01-13 16:04:10 PST

Created attachment 46520 [details]
patch

Comment 2 Dimitri Glazkov (Google) 2010-01-13 16:09:15 PST

Comment on attachment 46520 [details]
patch

LG, except:


> +        Cleaning up quota-tracking.html.

This could use a bit more description.

Comment 3 Dumitru Daniliuc 2010-01-13 16:09:56 PST

(In reply to comment #2)
> (From update of attachment 46520 [details])
> LG, except:
> 
> 
> > +        Cleaning up quota-tracking.html.
> 
> This could use a bit more description.

Will add more details before landing.

Comment 4 Dumitru Daniliuc 2010-01-13 16:22:46 PST

Landed as r53214.