RESOLVED FIXED 33628
LayoutTests/storage/quota-tracking.html needs to be cleaned up 
https://bugs.webkit.org/show_bug.cgi?id=33628
Summary LayoutTests/storage/quota-tracking.html needs to be cleaned up
Dumitru Daniliuc
Reported 2010-01-13 15:40:48 PST
Things that need to be cleaned up in quota-tracking.html: -- Remove all trailing whitespaces -- Refactor errorFunction(). Right now, it takes two parameters (tx, error) and is used as the error function for both executeSql() and transaction(). The problem is that transaction()'s error callback uses only one parameter. So if a transaction fails, the error gets assigned to the 'tx' parameter, and the 'error' parameter is left undefined; this leads to an exception when errorFunction() tries to log 'error.message'.
Attachments
patch (2.60 KB, patch)
2010-01-13 16:04 PST, Dumitru Daniliuc 		dglazkov: review+
dumi: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dumitru Daniliuc
Comment 1 2010-01-13 16:04:10 PST
Created attachment 46520 [details] patch
Dimitri Glazkov (Google)
Comment 2 2010-01-13 16:09:15 PST
Comment on attachment 46520 [details] patch LG, except: > + Cleaning up quota-tracking.html. This could use a bit more description.
Dumitru Daniliuc
Comment 3 2010-01-13 16:09:56 PST
(In reply to comment #2) > (From update of attachment 46520 [details]) > LG, except: > > > > + Cleaning up quota-tracking.html. > > This could use a bit more description. Will add more details before landing.
Dumitru Daniliuc
Comment 4 2010-01-13 16:22:46 PST
Landed as r53214.
Note You need to log in before you can comment on or make changes to this bug.