Bug 33619

Summary: Move more of the selection and caret painting code from Frame to SelectionController
Product: WebKit Reporter: Darin Adler <darin>
Component: New BugsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch mitz: review+

Darin Adler
Reported 2010-01-13 12:37:41 PST
Move more of the selection and caret painting code from Frame to SelectionController
Attachments
Patch (20.89 KB, patch)
2010-01-13 12:38 PST, Darin Adler 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2010-01-13 12:38:32 PST
Created attachment 46488 [details] Patch
WebKit Review Bot
Comment 2 2010-01-13 13:05:31 PST
Attachment 46488 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/184631
mitz
Comment 3 2010-01-13 13:22:15 PST
Comment on attachment 46488 [details] Patch > + "layout" is usedfor other purposes in this function. Typo: “usedfor” > - bool m_needsLayout : 1; // true if the caret and expectedVisible rectangles need to be calculated > + bool m_needsLayout; // true if the caret and expectedVisible rectangles need to be calculated I don’t know what expectedVisible is, in this comment that you’re moving. r=me but this apparently breaks the Qt build: <https://webkit-commit-queue.appspot.com/results/184631>.
Eric Seidel (no email)
Comment 4 2010-01-14 12:54:36 PST
Attachment 46488 [details] was posted by a committer and has review+, assigning to Darin Adler for commit.
Darin Adler
Comment 5 2010-01-14 12:56:09 PST
http://trac.webkit.org/changeset/53218
Note You need to log in before you can comment on or make changes to this bug.