| Summary: | Move more of the selection and caret painting code from Frame to SelectionController | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
| Component: | New Bugs | Assignee: | Darin Adler <darin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Darin Adler
2010-01-13 12:37:41 PST
Created attachment 46488 [details]
Patch
Attachment 46488 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/184631 Comment on attachment 46488 [details] Patch > + "layout" is usedfor other purposes in this function. Typo: “usedfor” > - bool m_needsLayout : 1; // true if the caret and expectedVisible rectangles need to be calculated > + bool m_needsLayout; // true if the caret and expectedVisible rectangles need to be calculated I don’t know what expectedVisible is, in this comment that you’re moving. r=me but this apparently breaks the Qt build: <https://webkit-commit-queue.appspot.com/results/184631>. Attachment 46488 [details] was posted by a committer and has review+, assigning to Darin Adler for commit.
|