|Summary:||Move more of the selection and caret painting code from Frame to SelectionController|
|Product:||WebKit||Reporter:||Darin Adler <darin>|
|Component:||New Bugs||Assignee:||Darin Adler <darin>|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Darin Adler 2010-01-13 12:37:41 PST
Move more of the selection and caret painting code from Frame to SelectionController
Comment 2 WebKit Review Bot 2010-01-13 13:05:31 PST
Attachment 46488 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/184631
Comment 3 mitz 2010-01-13 13:22:15 PST
Comment on attachment 46488 [details] Patch > + "layout" is usedfor other purposes in this function. Typo: “usedfor” > - bool m_needsLayout : 1; // true if the caret and expectedVisible rectangles need to be calculated > + bool m_needsLayout; // true if the caret and expectedVisible rectangles need to be calculated I don’t know what expectedVisible is, in this comment that you’re moving. r=me but this apparently breaks the Qt build: <https://webkit-commit-queue.appspot.com/results/184631>.
Comment 4 Eric Seidel (no email) 2010-01-14 12:54:36 PST
Attachment 46488 [details] was posted by a committer and has review+, assigning to Darin Adler for commit.