Bug 33615
| Summary: | Rename InjectedScript | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> |
| Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bweinstein, frances_c, joepeck, keishi, pfeldman, pmuellr, rik, ukai, yurys |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Geoffrey Garen
From https://bugs.webkit.org/show_bug.cgi?id=33469:
> 1. I don't think "InjectedScript", which is a fairly general phrase, is a good
> name to give to this technology. I'd prefer a name that conveyed the fact that
> this technology is only safe to use in limited circumstances. How about
> "InspectorHost" (inside the inspected page) and "InspectorClient" (the Web
> Inspector UI).
>
I agree with you that the naming is not the best. Currently the inspector
front-end delegate is called InjectedScriptHost. We should come up with
something more specific.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Frances Cornwall
If this wasn't renamed yet, let's rename InjectedScript to InspectorScript, it is only in use in the inspector parts.
Frances Cornwall
I am seeing that there is "injectedScript" in InspectorFrontEndAPI.js.
Frances Cornwall
Pull request: https://github.com/WebKit/WebKit/pull/20075