Bug 33599

Summary: [BREWMP] Port SharedTimer with IShell_SetTimerEx.
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Port SharedTimer to BREW
none
Port SharedTimer
eric: review-
Port SharedTimer none

Description Kwang Yul Seo 2010-01-13 08:16:49 PST 
As fireTime passed in setSharedTimerFireTime is the absolute time, we must calcalute the interval by subtracting currentTime() from fireTime and pass the result to ISHELL_SetTimerEx.
Comment 1 Kwang Yul Seo 2010-01-13 08:25:55 PST 
Created attachment 46467 [details]
Port SharedTimer to BREW
Comment 2 Kwang Yul Seo 2010-01-25 01:59:30 PST 
Created attachment 47330 [details]
Port SharedTimer

BREW -> BREWMP in ChangeLog
Comment 3 Eric Seidel (no email) 2010-01-26 14:51:20 PST 
Comment on attachment 47330 [details]
Port SharedTimer

 30 #undef COMPILE_ASSERT

Otherwise this looks fine.
Comment 4 Kwang Yul Seo 2010-01-26 17:14:16 PST 
Created attachment 47470 [details]
Port SharedTimer

#undef COMPILE_ASSERT is removed
Comment 5 Eric Seidel (no email) 2010-02-01 15:29:56 PST 
Comment on attachment 47470 [details]
Port SharedTimer

OK.
Comment 6 WebKit Commit Bot 2010-02-01 21:02:01 PST 
Comment on attachment 47470 [details]
Port SharedTimer

Clearing flags on attachment: 47470

Committed r54200: <http://trac.webkit.org/changeset/54200>
Comment 7 WebKit Commit Bot 2010-02-01 21:02:07 PST 
All reviewed patches have been landed.  Closing bug.