Bug 33597

Summary: [Android] [Qt] The JSC ScriptController does not consider Touch Events user gestures.
Product: WebKit Reporter: Ben Murdoch <benm>
Component: WebCore Misc.Assignee: Ben Murdoch <benm>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking, commit-queue, hausmann, kim.1.gronholm, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 32485    
Attachments:
Description Flags
Proposed Patch.
none
Patch sans-tab. none

Description Ben Murdoch 2010-01-13 06:55:19 PST
As with other UI events (such as keyboard and mouse events) the ScriptController should consider touch events when determining if an event is a user gesture.

I have a small patch ready to fix this.
Comment 1 Ben Murdoch 2010-01-13 07:18:05 PST
Created attachment 46456 [details]
Proposed Patch.
Comment 2 WebKit Review Bot 2010-01-13 07:20:49 PST
Attachment 46456 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1
Comment 3 Ben Murdoch 2010-01-13 07:23:47 PST
Created attachment 46457 [details]
Patch sans-tab.
Comment 4 Simon Hausmann 2010-01-13 07:38:43 PST
Comment on attachment 46457 [details]
Patch sans-tab.

r=me
Comment 5 Ben Murdoch 2010-01-13 07:41:56 PST
Comment on attachment 46457 [details]
Patch sans-tab.

cq+ for landing.
Comment 6 WebKit Commit Bot 2010-01-13 09:03:43 PST
Comment on attachment 46457 [details]
Patch sans-tab.

Clearing flags on attachment: 46457

Committed r53191: <http://trac.webkit.org/changeset/53191>
Comment 7 WebKit Commit Bot 2010-01-13 09:03:49 PST
All reviewed patches have been landed.  Closing bug.