Bug 33586

Summary:

[Android] appendClassName in jni_runtime.cpp uses JSC-specific UString type

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Steve Block <steveblock>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

android-webkit-unforking, barraclough, commit-queue, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

Android

OS:

Android

Bug Depends on:

Bug Blocks:

32154

Attachments:

Description	Flags
Patch 1 for Bug 33586	none

Steve Block

Reported 2010-01-13 04:22:48 PST

appendClassName is a static helper function used in jni_runtime.cpp. This file is largely script engine independent. However, appendClassName uses the JSC-specific UString type, which causes problems on Android, where we can build with JSC or V8. The function should be updated to use a non-JSC-specific type.

Attachments
Patch 1 for Bug 33586 (1.88 KB, patch) 2010-01-13 09:51 PST, Steve Block	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Steve Block

Comment 1 2010-01-13 09:30:13 PST

jni_runtime was recently (http://trac.webkit.org/changeset/52329) updated to use JSC::StringBuilder, rather than UString, but the problem still stands.

Steve Block

Comment 2 2010-01-13 09:51:16 PST

Created attachment 46471 [details] Patch 1 for Bug 33586 Uses WebCore::SringBuilder in place of JSC::StringBuilder. Note that this also avoids the use of UString::ascii, which according to UString.h, should only be used for debugging purposes.

WebKit Commit Bot

Comment 3 2010-01-13 10:30:12 PST

Comment on attachment 46471 [details] Patch 1 for Bug 33586 Clearing flags on attachment: 46471 Committed r53193: <http://trac.webkit.org/changeset/53193>

WebKit Commit Bot

Comment 4 2010-01-13 10:30:17 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.