Bug 33575 – [Gtk] Compiler warning: comparisons like 'X<=Y<=Z' do not have their mathematical meaning

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Magnus Boman]

Compiler complains about "comparisons like 'X<=Y<=Z' do not have their mathematical meaning" in WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp

Here's a patch. Not sure if I got it right though :-)


Index: WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp
===================================================================
--- WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp.orig  2010-01-05 08:53:00.000000000 +1100
+++ WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp       2010-01-13 16:59:29.000000000 +1100
@@ -852,11 +852,11 @@ static HashSet<String> mimeTypeCache()
                         if (G_VALUE_TYPE(layer) == GST_TYPE_INT_RANGE) {
                             gint minLayer = gst_value_get_int_range_min(layer);
                             gint maxLayer = gst_value_get_int_range_max(layer);
-                            if (minLayer <= 1 <= maxLayer)
+                            if (minLayer <= 1 && 1 <= maxLayer)
                                 cache.add(String("audio/mp1"));
-                            if (minLayer <= 2 <= maxLayer)
+                            if (minLayer <= 2 && 2 <= maxLayer)
                                 cache.add(String("audio/mp2"));
-                            if (minLayer <= 3 <= maxLayer)
+                            if (minLayer <= 3 && 3 <= maxLayer)
                                 cache.add(String("audio/mp3"));
                         }
                     }

[Alexey Proskuryakov]

That's clearly a bug. Would you be willing to submit a patch for review, as described in <http://webkit.org/coding/contributing.html>?

[Philippe Normand]

Thanks Magnus for spotting this, it is my mistake :( I will try your patch and attach it here if you don't mind

[Philippe Normand]

Created attachment 46556 [details]
fix compiler warnings

[Xan Lopez]

Comment on attachment 46556 [details]
fix compiler warnings

LGTM.

[Magnus Boman]

(In reply to comment #2)
> Thanks Magnus for spotting this, it is my mistake :( I will try your patch and
> attach it here if you don't mind

Philippe,
I don't mind. Just wasn't sure that the logic was according to my patch.

[Eric Seidel (no email)]

Attachment 46556 [details] was posted by a committer and has review+, assigning to Philippe Normand for commit.

[Philippe Normand]

Landed as r53329. Thanks!