Bug 33567

Summary: [BREWMP] Port WTF's currentTime
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Port currentTime to BREW
none
Port WTF's currentTime
eric: review-
Port WTF's currentTime
eric: review+, eric: commit-queue-
Port WTF's currentTime none

Description Kwang Yul Seo 2010-01-12 18:12:35 PST 
Implement WTF::currentTime for BREW with GETUTCSECONDS and GETTIMEMS.
Comment 1 Kwang Yul Seo 2010-01-12 18:18:00 PST 
Created attachment 46418 [details]
Port currentTime to BREW
Comment 2 Kwang Yul Seo 2010-01-22 17:44:11 PST 
Created attachment 47251 [details]
Port WTF's currentTime

Use PLATFORM(BREWMP)
Comment 3 Kwang Yul Seo 2010-01-22 17:52:30 PST 
"#undef COMPILE_ASSERT" is required because both WTF and BREW defines COMPILE_ASSERT. Unless we prefix WTF_ to COMPILE_ASSERT defined Assertions.h, I have to put "#undef COMPILE_ASSERT" every place where BREW headers are used. This is quite ugly.
Comment 4 Eric Seidel (no email) 2010-01-26 14:42:36 PST 
Comment on attachment 47251 [details]
Port WTF's currentTime

See my comments in the other bug.  I think we should fix wtf/Assertions.h instead of each file.

Otherwise looks sane.
Comment 5 Kwang Yul Seo 2010-01-26 16:35:46 PST 
Created attachment 47461 [details]
Port WTF's currentTime

Remove "#undef COMPILE_ASSERT"
Comment 6 Eric Seidel (no email) 2010-01-26 16:45:24 PST 
Comment on attachment 47461 [details]
Port WTF's currentTime

Looks sane.  Looks like the patch fails to apply though, so it can't be cq+'d w/o first being updated.
Comment 7 Kwang Yul Seo 2010-01-26 17:02:10 PST 
Created attachment 47464 [details]
Port WTF's currentTime

I generated a new diff with the tools.
Comment 8 Eric Seidel (no email) 2010-02-01 15:28:34 PST 
Comment on attachment 47464 [details]
Port WTF's currentTime

OK.
Comment 9 WebKit Commit Bot 2010-02-01 17:33:59 PST 
Comment on attachment 47464 [details]
Port WTF's currentTime

Clearing flags on attachment: 47464

Committed r54183: <http://trac.webkit.org/changeset/54183>
Comment 10 WebKit Commit Bot 2010-02-01 17:34:05 PST 
All reviewed patches have been landed.  Closing bug.