Bug 33560

Summary: [chromium] setReplacing call in WebFrameImpl.cpp is causing problems with multipart code
Product: WebKit Reporter: Tony Chang <tony>
Component: WebCore Misc.Assignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Description Tony Chang 2010-01-12 16:39:40 PST
In bug 31446 comment 7, Darin asks if WebFrameImpl::loadData call to setReplacing could that interact in an interesting way with this code.  Turns out he was right!  This is causing an assert to trigger with the code added in r53143 because we're trying to replace a document that already exists.

Fix coming up.
Comment 1 Tony Chang 2010-01-12 16:46:48 PST
Created attachment 46413 [details]
Patch
Comment 2 Adam Barth 2010-01-12 17:12:43 PST
Comment on attachment 46413 [details]
Patch

I think this is ok, but I'm not 100% sure.
Comment 3 WebKit Commit Bot 2010-01-12 17:29:44 PST
Comment on attachment 46413 [details]
Patch

Clearing flags on attachment: 46413

Committed r53171: <http://trac.webkit.org/changeset/53171>
Comment 4 WebKit Commit Bot 2010-01-12 17:29:49 PST
All reviewed patches have been landed.  Closing bug.