Bug 33546

Summary:

Add V8 bindings for PopStateEvent

Product:

WebKit

Reporter:

Darin Fisher (:fishd, Google) <fishd>

Component:

WebCore JavaScript

Assignee:

Darin Fisher (:fishd, Google) <fishd>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
v1 patch	dglazkov: review+

Description Darin Fisher (:fishd, Google) 2010-01-12 12:35:01 PST

Add V8 bindings for PopStateEvent

Comment 1 Darin Fisher (:fishd, Google) 2010-01-12 12:35:50 PST

Created attachment 46390 [details]
v1 patch

Comment 2 Dimitri Glazkov (Google) 2010-01-12 12:45:53 PST

Comment on attachment 46390 [details]
v1 patch

Yay, except:

> +
> +    // NOTE: v8String converts a null String into an empty v8::String :(
> +    return v8String(state->toString());

v8StringOrNull

Comment 3 Darin Fisher (:fishd, Google) 2010-01-12 13:28:26 PST

Landed as http://trac.webkit.org/changeset/53161