Bug 33536

Summary: Web Inspector: Optimize WebInspector.TimelineGrid.prototype.updateDividers
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch none

Description Alexander Pavlov (apavlov) 2010-01-12 09:43:26 PST 
On pages with really many resources, WebInspector.TimelineGrid.prototype.updateDividers works too slowly (which results in slow feedback on scrolling/adding items and view resizing in the Resources and Timeline panels).
Comment 1 Alexander Pavlov (apavlov) 2010-01-12 10:17:28 PST 
Created attachment 46381 [details]
patch
Comment 2 WebKit Commit Bot 2010-01-12 12:56:40 PST 
Comment on attachment 46381 [details]
patch

Rejecting patch 46381 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11914 test cases.
fast/profiler/stop-profiling-after-setTimeout.html -> crashed

Exiting early after 1 failures. 7859 tests run.
254.88s total testing time

7858 test cases (99%) succeeded
1 test case (<1%) crashed
3 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/182685
Comment 3 Eric Seidel (no email) 2010-01-12 14:59:02 PST 
Comment on attachment 46381 [details]
patch

Bug 32643.  Stupid flakey tests.
Comment 4 WebKit Commit Bot 2010-01-12 15:34:27 PST 
Comment on attachment 46381 [details]
patch

Clearing flags on attachment: 46381

Committed r53167: <http://trac.webkit.org/changeset/53167>
Comment 5 WebKit Commit Bot 2010-01-12 15:34:35 PST 
All reviewed patches have been landed.  Closing bug.