Bug 33536 - Web Inspector: Optimize WebInspector.TimelineGrid.prototype.updateDividers
: Web Inspector: Optimize WebInspector.TimelineGrid.prototype.updateDividers
Status: RESOLVED FIXED
: WebKit
Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-01-12 09:43 PST by
Modified: 2010-01-12 15:34 PST (History)


Attachments
patch (3.45 KB, patch)
2010-01-12 10:17 PST, Alexander Pavlov (apavlov)
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-01-12 09:43:26 PST
On pages with really many resources, WebInspector.TimelineGrid.prototype.updateDividers works too slowly (which results in slow feedback on scrolling/adding items and view resizing in the Resources and Timeline panels).
------- Comment #1 From 2010-01-12 10:17:28 PST -------
Created an attachment (id=46381) [details]
patch
------- Comment #2 From 2010-01-12 12:56:40 PST -------
(From update of attachment 46381 [details])
Rejecting patch 46381 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11914 test cases.
fast/profiler/stop-profiling-after-setTimeout.html -> crashed

Exiting early after 1 failures. 7859 tests run.
254.88s total testing time

7858 test cases (99%) succeeded
1 test case (<1%) crashed
3 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/182685
------- Comment #3 From 2010-01-12 14:59:02 PST -------
(From update of attachment 46381 [details])
Bug 32643.  Stupid flakey tests.
------- Comment #4 From 2010-01-12 15:34:27 PST -------
(From update of attachment 46381 [details])
Clearing flags on attachment: 46381

Committed r53167: <http://trac.webkit.org/changeset/53167>
------- Comment #5 From 2010-01-12 15:34:35 PST -------
All reviewed patches have been landed.  Closing bug.