[Chromium] Re-work webkit_unit_tests so that WebKit is initialized only once

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Darin Fisher (:fishd, Google)]

[Chromium] Re-work webkit_unit_tests so that WebKit is initialized only once

It was wrong that I re-initialized WebKit for each test case.  That may cause problems down the road since background threads may try to call through to the WebKitClient.

Instead, we should change to only initialize WebKit once.

[Darin Fisher (:fishd, Google)]

Created attachment 46321 [details]
v1 patch

[Darin Fisher (:fishd, Google)]

Created attachment 46322 [details]
v2 patch (adds a comment)

[WebKit Review Bot]

Attachment 46321 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Skipping input 'WebKit/chromium/tests/WebKitTest.h': Can't open for reading
WebKit/chromium/tests/RunAllTests.cpp:32:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/RunAllTests.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/tests/KURLTest.cpp:36:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 3

[WebKit Review Bot]

Attachment 46322 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Skipping input 'WebKit/chromium/tests/WebKitTest.h': Can't open for reading
WebKit/chromium/tests/RunAllTests.cpp:32:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/RunAllTests.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/tests/KURLTest.cpp:36:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 3

[Darin Fisher (:fishd, Google)]

I'm ignoring those style errors.  The style tool gets confused about header usage in WebKit/chromium/*

[Dimitri Glazkov (Google)]

Comment on attachment 46322 [details]
v2 patch (adds a comment)

ok.

[Darin Fisher (:fishd, Google)]

Landed as http://trac.webkit.org/changeset/53144

[Adam Barth]

(In reply to comment #5)
> I'm ignoring those style errors.  The style tool gets confused about header
> usage in WebKit/chromium/*

Is the issue the lack of config.h?  We should fix the style checker not to be confused.