Summary: | [Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jeremy Orlow <jorlow> | ||||||
Component: | New Bugs | Assignee: | Jeremy Orlow <jorlow> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Jeremy Orlow
2010-01-11 14:13:35 PST
Created attachment 46308 [details]
Patch
Comment on attachment 46308 [details] Patch > Index: WebCore/ChangeLog ... > + No new tests. (OOPS!) ^^^ need to delete this line > Index: WebKit/chromium/public/WebKitClient.h ... > + // THIS IS DEPRICATED. WebViewClient::getSessionStorageNamespace() is the new way to access this. ^^^ deprecated > Index: WebKit/chromium/public/WebViewClient.h > + // Session Storage ------------------------------------------------------ > + > + // Get the session storage namespace associated with this WebView. > + virtual WebStorageNamespace* getSessionStorageNamespace() { return 0; } why isn't this called createSessionStorageNamespace? if the embedder owns the returned pointer, then you should just call this sessionStorageNamespace. Created attachment 46315 [details]
Patch
Comment on attachment 46315 [details] Patch > Index: WebKit/chromium/public/WebViewClient.h ... > + // Get the session storage namespace associated with this WebView. > + virtual WebStorageNamespace* createSessionStorageNamespace() { return 0; } Fix the comment to say "Create a..." Also, please move this up into the factory section of WebViewClient. R=me, but please fix these before committing. Attachment 46315 [details] was posted by a committer and has review+, assigning to Jeremy Orlow for commit.
Committed r53180: <http://trac.webkit.org/changeset/53180> Re-opening as my previous patch had to be reverted. Problem fixed upstream. Will re-land the r+'ed patch. Committed r53210: <http://trac.webkit.org/changeset/53210> |