Bug 33427

Summary:

Web Inspector: Do not repaint line numbers while editing within line.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, joepeck, rik, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed change	timothy: review+

Pavel Feldman

Reported 2010-01-09 13:04:09 PST

(making typing even snappier)

Attachments
[PATCH] Proposed change (6.25 KB, patch) 2010-01-09 13:06 PST, Pavel Feldman	timothy: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2010-01-09 13:06:03 PST

Created attachment 46213 [details] [PATCH] Proposed change

Timothy Hatcher

Comment 2 2010-01-09 13:10:58 PST

Comment on attachment 46213 [details] [PATCH] Proposed change > + if (oldRange.isEmpty() && newRange.isEmpty() && oldRange.startLine === newRange.startLine) > + // Nothing to repaint. > + return; This should have braces, even in the comment case, since it is multiline. See style guide, Braces clause 3.

Pavel Feldman

Comment 3 2010-01-10 11:07:39 PST

(In reply to comment #2) > (From update of attachment 46213 [details]) > > + if (oldRange.isEmpty() && newRange.isEmpty() && oldRange.startLine === newRange.startLine) > > + // Nothing to repaint. > > + return; > > This should have braces, even in the comment case, since it is multiline. See > style guide, Braces clause 3. Done. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/TextEditor.js Committed r53051

Note You need to log in before you can comment on or make changes to this bug.