Summary: | Retry writes to QueueStatusServer when we get 500 errors | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Adam Barth
2010-01-08 17:56:14 PST
Created attachment 46186 [details]
Patch
Comment on attachment 46186 [details]
Patch
I think this ability should be made general (i'm sure we'll need it in other places). I also think this should eventually stop. I don't think we should hang the queue forever if AppEngine is really wedged, or?
A general method would take some sort of closure and have some default backoff amount, and eventual "give-up" timeout, no?
Comment on attachment 46186 [details]
Patch
This block of code is actually huge as is. So breaking it down into (a) function(s), whether for use with some helper retry-thingy or not, seems useful.
Created attachment 46226 [details]
Patch
Comment on attachment 46226 [details]
Patch
So hot.
|