| Summary: | Font fallback kills SVG kerning | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
| Component: | Text | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ddkilzer, eric, mitz, zimmermann | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Mac (Intel) | ||||||||
| OS: | OS X 10.6 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 33374 | ||||||||
| Attachments: |
|
||||||||
Created attachment 46203 [details]
Cache font attributes seperately for different typesetting features
Comment on attachment 46203 [details]
Cache font attributes seperately for different typesetting features
Looks very nice! I assume you've tried a pixel test run in svg/ as well, without problems? If yes, r=me.
Comment on attachment 46203 [details] Cache font attributes seperately for different typesetting features > + Cache font attributes seperately for different typesetting features. Typo: "separately" Comment on attachment 46203 [details] Cache font attributes seperately for different typesetting features > + (WebCore::SimpleFontData::getCFStringAttributes): Look up the attributes > + dictionary in the map and initialize in necessary. Typo: "if necessary". |
Created attachment 46159 [details] test case Steps to reproduce: 1. Unpack the attached archive into LayoutTests directory. 2. run-webkit-tests --pixel --tolerance 0 kerning/2.svg 3. run-webkit-tests --pixel --tolerance 0 kerning Results: 2.svg fails, because kerning doesn't happen.