Bug 33390

Summary: bindings/v8/DOMData is missing a virtual destructor
Product: WebKit Reporter: Andrei Popescu <andreip>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Severity: Normal CC: abarth, android-webkit-unforking, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Description Flags
Patch none

Description Andrei Popescu 2010-01-08 10:32:40 PST
DOMData is the base class for ChildThreadDOMData and MainThreadDOMData classes but it does not have a virtual destructor. While this isn't currently causing any leaks, since there are no instances of ChildThreadDOMData or MainThreadDOMData that are manipulated via a DOMData pointer, the ARM GCC compiler generates the following compilation error:

"/WebCore/bindings/v8/DOMData.h:45: error: 'class WebCore::DOMData' has virtual functions and accessible non-virtual destructor"

We therefore need to add a virtual destructor to DOMData.
Comment 1 Adam Barth 2010-01-08 17:24:19 PST
Do you have a patch for this, or should I write one?
Comment 2 Adam Barth 2010-01-08 17:27:04 PST
Created attachment 46184 [details]
Comment 3 Adam Barth 2010-01-08 17:28:02 PST
(Please wait for the chromium-ews because I didn't compile this locally.)
Comment 4 Dmitry Titov 2010-01-08 23:13:56 PST
Comment on attachment 46184 [details]

r=me, cq+
Comment 5 WebKit Commit Bot 2010-01-08 23:40:10 PST
Comment on attachment 46184 [details]

Clearing flags on attachment: 46184

Committed r53037: <http://trac.webkit.org/changeset/53037>
Comment 6 WebKit Commit Bot 2010-01-08 23:40:15 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Andrei Popescu 2010-01-09 04:24:01 PST
(In reply to comment #1)
> Do you have a patch for this, or should I write one?

Yes, I had the patch. I just got interrupted before I could upload it, then had to leave to catch my train. I woke up this morning and found the bug fixed. Thank you :)

I'll try to upload my patches faster in the future.
Comment 8 Adam Barth 2010-01-09 10:03:22 PST
> I'll try to upload my patches faster in the future.

No worries.  It just seemed like a trivial bug in code I wrote, so I fixed it.