Bug 33376

Summary:

commit-queue should run run-javascriptcore-tests

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, kent.hansen, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	hausmann: review+

Eric Seidel (no email)

Reported 2010-01-08 04:08:38 PST

commit-queue should run run-javascriptcore-tests the commit-queue landed 2 patches which broke lots of javascriptcore tests tongiht. This could have been prevented if we just ran run-javascriptcore-tests. :(

Attachments
Patch (2.43 KB, patch) 2010-01-08 04:43 PST, Eric Seidel (no email)	hausmann: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-01-08 04:32:55 PST

I'm not sure what port flags will need to be passed otherwise this would be simple.

Eric Seidel (no email)

Comment 2 2010-01-08 04:33:19 PST

Then again, i'm not sure that it matters, since no other port besides mac will use this at first.

Eric Seidel (no email)

Comment 3 2010-01-08 04:43:13 PST

Created attachment 46132 [details] Patch

WebKit Review Bot

Comment 4 2010-01-08 04:48:47 PST

style-queue ran check-webkit-style on attachment 46132 [details] without any errors.

WebKit Commit Bot

Comment 5 2010-01-08 04:59:14 PST

Committed r52989: <http://trac.webkit.org/changeset/52989>

Note You need to log in before you can comment on or make changes to this bug.