Bug 33358

Summary: commit-queue is stuck spinning due to exception
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, mbelshe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+

Eric Seidel (no email)
Reported 2010-01-07 18:02:31 PST
commit-queue is stuck spinning due to exception Landing patch Adding ['webkit-bot-watchers@googlegroups.com'] to the CC list for bug 32641 Traceback (most recent call last): File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/queueengine.py", line 104, in run self._delegate.process_work_item(work_item) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/commands/queues.py", line 176, in process_work_item self._cc_watchers(patch["bug_id"]) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/commands/queues.py", line 65, in _cc_watchers log("Failed to CC watchers: %s." % e) File "/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/HTMLParser.py", line 59, in __str__ result = self.msg AttributeError: 'ParseError' object has no attribute 'msg' I should have noticed sooner. Oops.
Attachments
Patch (1.46 KB, patch)
2010-01-07 18:16 PST, Eric Seidel (no email) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-01-07 18:16:30 PST
Created attachment 46104 [details] Patch
Adam Barth
Comment 2 2010-01-07 18:17:46 PST
Comment on attachment 46104 [details] Patch yep
Eric Seidel (no email)
Comment 3 2010-01-07 18:22:38 PST
Committed r52965: <http://trac.webkit.org/changeset/52965>
Eric Seidel (no email)
Comment 4 2010-01-07 18:23:18 PST
Ok. Landed and restarted the commit-queue. Sadly it's 10 patches under at this point. It will catch up this evening I"m sure.
Note You need to log in before you can comment on or make changes to this bug.