[Chromium] Upstream webkit unit tests from the chromium repository

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Darin Fisher (:fishd, Google)]

[Chromium] Upstream webkit unit tests from the chromium repository

The chromium repository has a number of unit tests that test WebKit and WebCore classes.  My plan is to upstream these into WebKit/chromium/tests/.  A webkit_unit_tests executable will be built, which we can then run on the build bots.

Initial patch will just contain one test and the associated build changes to get the ball rolling.

[Darin Fisher (:fishd, Google)]

Created attachment 46141 [details]
v1 patch

[WebKit Review Bot]

Attachment 46141 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/tests/WebKitTest.h:36:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/tests/KURLTest.cpp:35:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/KURLTest.cpp:37:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/KURLTest.cpp:78:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/chromium/tests/KURLTest.cpp:79:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/chromium/tests/KURLTest.cpp:80:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/chromium/tests/KURLTest.cpp:81:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/chromium/tests/KURLTest.cpp:82:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/chromium/tests/KURLTest.cpp:124:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/chromium/tests/KURLTest.cpp:128:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/chromium/tests/KURLTest.cpp:131:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/chromium/tests/KURLTest.cpp:134:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/chromium/tests/KURLTest.cpp:147:  Use 0 instead of NULL.  [readability/null] [4]
WebKit/chromium/tests/KURLTest.cpp:160:  ascii_kurl is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit/chromium/tests/KURLTest.cpp:224:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/chromium/tests/KURLTest.cpp:398:  Use 0 instead of NULL.  [readability/null] [4]
WebKit/chromium/tests/KURLTest.cpp:412:  Use 0 instead of NULL.  [readability/null] [4]
WebKit/chromium/tests/KURLTest.cpp:478:  Use 0 instead of NULL.  [readability/null] [4]
WebKit/chromium/tests/KURLTest.cpp:488:  Use 0 instead of NULL.  [readability/null] [4]
WebKit/chromium/tests/KURLTest.cpp:593:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/tests/KURLTest.cpp:595:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/tests/KURLTest.cpp:604:  Missing space after ,  [whitespace/comma] [3]
WebKit/chromium/tests/KURLTest.cpp:608:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 23

[Dimitri Glazkov (Google)]

Comment on attachment 46141 [details]
v1 patch

LGTM after you take care of style-elves compaints.

[Darin Fisher (:fishd, Google)]

Landed as http://trac.webkit.org/changeset/53001