Bug 33347

Summary: [v8] regression: didDestroyScriptContextForFrame no longer called
Product: WebKit Reporter: Matt Perry <mpcomplete>
Component: WebCore JavaScriptAssignee: Matt Perry <mpcomplete>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
add the call back none

Description Matt Perry 2010-01-07 14:59:38 PST 
This call seems to have gotten lost in the V8Proxy refactoring. I just need to add it back to V8DOMWindowShell::disposeContextHandles.
Comment 1 Matt Perry 2010-01-07 15:11:27 PST 
Created attachment 46089 [details]
add the call back
Comment 2 WebKit Review Bot 2010-01-07 15:14:44 PST 
style-queue ran check-webkit-style on attachment 46089 [details] without any errors.
Comment 3 Adam Barth 2010-01-07 15:43:39 PST 
Comment on attachment 46089 [details]
add the call back

Looks good.  Sorry I dropped the call.  :(
Comment 4 Adam Barth 2010-01-08 10:54:51 PST 
Comment on attachment 46089 [details]
add the call back

Clearing flags on attachment: 46089

Committed r52996: <http://trac.webkit.org/changeset/52996>
Comment 5 Adam Barth 2010-01-08 10:54:57 PST 
All reviewed patches have been landed.  Closing bug.