Summary: | Create a renderer for <object> and <embed> | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | mitz, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2010-01-07 12:26:57 PST
Created attachment 46076 [details]
Patch
Attachment 46076 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/rendering/RenderEmbeddedObject.cpp:146: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
WebCore/rendering/RenderEmbeddedObject.cpp:150: One space before end of line comments [whitespace/comments] [5]
WebCore/rendering/RenderEmbeddedObject.cpp:152: One space before end of line comments [whitespace/comments] [5]
WebCore/rendering/RenderEmbeddedObject.cpp:156: Declaration has space between type name and * in HTMLElement *embedOrObject [whitespace/declaration] [3]
WebCore/rendering/RenderEmbeddedObject.cpp:175: Declaration has space between type name and * in Node *child [whitespace/declaration] [3]
WebCore/rendering/RenderEmbeddedObject.cpp:233: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
WebCore/rendering/RenderEmbeddedObject.cpp:247: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
WebCore/rendering/RenderEmbeddedObject.cpp:252: Declaration has space between type name and * in HTMLEmbedElement *o [whitespace/declaration] [3]
Total errors found: 8
|