Bug 33338 – Create a renderer for <object> and <embed>

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

RenderPartObject, which is used for iframe, object and embed, has code that is mostly plugin related. I also need to add some more plugin-specific methods, so I'd like to subclass RenderPartObject for plugins.

My proposed name is RenderEmbeddedObject.

[Simon Fraser (smfr)]

Created attachment 46076 [details]
Patch

[WebKit Review Bot]

Attachment 46076 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/rendering/RenderEmbeddedObject.cpp:146:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
WebCore/rendering/RenderEmbeddedObject.cpp:150:  One space before end of line comments  [whitespace/comments] [5]
WebCore/rendering/RenderEmbeddedObject.cpp:152:  One space before end of line comments  [whitespace/comments] [5]
WebCore/rendering/RenderEmbeddedObject.cpp:156:  Declaration has space between type name and * in HTMLElement *embedOrObject  [whitespace/declaration] [3]
WebCore/rendering/RenderEmbeddedObject.cpp:175:  Declaration has space between type name and * in Node *child  [whitespace/declaration] [3]
WebCore/rendering/RenderEmbeddedObject.cpp:233:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/rendering/RenderEmbeddedObject.cpp:247:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/rendering/RenderEmbeddedObject.cpp:252:  Declaration has space between type name and * in HTMLEmbedElement *o  [whitespace/declaration] [3]
Total errors found: 8

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/52946
and
http://trac.webkit.org/changeset/52947