Bug 33334

Summary:

Removed an unnecessary argument from LayoutTests/fast/dom/elementFromPoint-relative-to-viewport.html

Product:

WebKit

Reporter:

Afonso Costa <arabelo>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Proposed patch	darin: review-, darin: commit-queue-
Proposed patch - v2	none

Description Afonso Costa 2010-01-07 11:32:41 PST

Created attachment 46070 [details]
Proposed patch

As the bug #30034 is fixed, the zoomOrNot argument is unnecessary.

Comment 1 WebKit Review Bot 2010-01-07 11:38:16 PST

style-queue ran check-webkit-style on attachment 46070 [details] without any errors.

Comment 2 Darin Adler 2010-01-07 12:34:17 PST

Comment on attachment 46070 [details]
Proposed patch

The zoomOrNot argument is not necessary, but we do need to test with zoomPageOut, so please don't remove that line. The rest of the patch is fine.

Comment 3 Afonso Costa 2010-01-07 13:07:09 PST

Created attachment 46079 [details]
Proposed patch - v2

Sorry, I'm confused about the old values and the zoomPageOut operation. I've updated the proposed patch.

Thanks Darin.

Comment 4 WebKit Review Bot 2010-01-07 13:10:46 PST

style-queue ran check-webkit-style on attachment 46079 [details] without any errors.

Comment 5 WebKit Commit Bot 2010-01-07 21:54:54 PST

Comment on attachment 46079 [details]
Proposed patch - v2

Clearing flags on attachment: 46079

Committed r52971: <http://trac.webkit.org/changeset/52971>

Comment 6 WebKit Commit Bot 2010-01-07 21:54:59 PST

All reviewed patches have been landed.  Closing bug.