Bug 33331

Summary: WebHostedNetscapePluginView should pass acceleratedCompositingEnabled bool to NetscapePluginHostManager when instantiating plug-ins
Product: WebKit Reporter: Kevin Decker <kdecker>
Component: Plug-insAssignee: Kevin Decker <kdecker>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.6   
Attachments:
Description Flags
proposed fix.
simon.fraser: review-
Updated patch per Simon's feedback simon.fraser: review+

Kevin Decker
Reported 2010-01-07 11:15:43 PST
WebHostedNetscapePluginView should pass acceleratedCompositingEnabled bool to NetscapePluginHostManager when instantiating plug-ins
Attachments
proposed fix. (4.48 KB, patch)
2010-01-07 11:18 PST, Kevin Decker 		simon.fraser: review-
DetailsFormatted DiffDiff
Updated patch per Simon's feedback (4.66 KB, patch)
2010-01-07 12:23 PST, Kevin Decker 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kevin Decker
Comment 1 2010-01-07 11:18:30 PST
Created attachment 46067 [details] proposed fix.
Simon Fraser (smfr)
Comment 2 2010-01-07 11:31:52 PST
Comment on attachment 46067 [details] proposed fix. > _proxy = NetscapePluginHostManager::shared().instantiatePlugin(_pluginPackage.get(), self, _MIMEType.get(), _attributeKeys.get(), _attributeValues.get(), userAgent, _sourceURL.get(), > - _mode == NP_FULL, _isPrivateBrowsingEnabled); > + _mode == NP_FULL, _isPrivateBrowsingEnabled, [[[self webView] preferences] acceleratedCompositingEnabled]); This also needs to check USE(ACCELERATED_COMPOSITING).
Kevin Decker
Comment 3 2010-01-07 12:23:17 PST
Created attachment 46071 [details] Updated patch per Simon's feedback
Kevin Decker
Comment 4 2010-01-07 12:27:04 PST
Committed revision 52942.
Note You need to log in before you can comment on or make changes to this bug.