Bug 33321

Summary: Don't store RegExp flags string representation
Product: WebKit Reporter: Kent Hansen <kent.hansen>
Component: JavaScriptCoreAssignee: Kent Hansen <kent.hansen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed patch none

Description Kent Hansen 2010-01-07 07:06:06 PST 
There's a FIXME in RegExp.h stating that it shouldn't be necessary to store the original flags string. Well, actually it isn't; RegExp.prototype.toString already uses the flag bits to reconstruct the string.
Comment 1 Kent Hansen 2010-01-07 07:11:24 PST 
Created attachment 46050 [details]
proposed patch
Comment 2 WebKit Review Bot 2010-01-07 07:15:56 PST 
style-queue ran check-webkit-style on attachment 46050 [details] without any errors.
Comment 3 WebKit Commit Bot 2010-01-08 03:33:04 PST 
Comment on attachment 46050 [details]
proposed patch

Clearing flags on attachment: 46050

Committed r52983: <http://trac.webkit.org/changeset/52983>
Comment 4 WebKit Commit Bot 2010-01-08 03:33:13 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Eric Seidel (no email) 2010-01-08 04:10:02 PST 
Reverted r52983 for reason:

Broke 59 JavaScriptCore tests.  I don't think Kent knew about run-javascriptcore-tests.  Sadly neither does the commit-bot, yet.

Committed r52987: <http://trac.webkit.org/changeset/52987>
Comment 6 Eric Seidel (no email) 2010-01-08 04:30:20 PST 
I think my rollout may have been wrong. :(  I think the bots are just flakey.  They reported more failures after the first failures which seemed to be correlated to this patch.  I'll wait for them to calm down and then roll this back in if necessary.

Lesson:  You can't trust the bots.
Comment 7 Eric Seidel (no email) 2010-01-08 04:42:16 PST 
I will have the commit-queue land this again one bug 33376 is landed.
Comment 8 Eric Seidel (no email) 2010-01-08 05:03:00 PST 
Comment on attachment 46050 [details]
proposed patch

Sorry for the troubles.  The commit-queue will re-land this shortly (and will re-confirm that it does not break run-javascriptcore-tests before landing).
Comment 9 WebKit Commit Bot 2010-01-08 17:57:59 PST 
Comment on attachment 46050 [details]
proposed patch

Clearing flags on attachment: 46050

Committed r53032: <http://trac.webkit.org/changeset/53032>
Comment 10 WebKit Commit Bot 2010-01-08 17:58:04 PST 
All reviewed patches have been landed.  Closing bug.