Summary: | [Qt] Build fix when FAST_MALLOC_MATCH_VALIDATION=1 | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zoltan Horvath <zoltan> | ||||||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | webkit.review.bot, zecke | ||||||||||||
Priority: | P2 | Keywords: | Qt | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | PC | ||||||||||||||
OS: | Linux | ||||||||||||||
Attachments: |
|
Description
Zoltan Horvath
2010-01-07 01:38:10 PST
Created attachment 46032 [details]
proposed patch
Attachment 46032 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/wtf/FastMalloc.cpp:3798: One space before end of line comments [whitespace/comments] [5]
Total errors found: 1
The patch looks fine... some comments would be: - Refer to the commit that broke/added it. - You could use the same thing as with new_ptr (as in the original patch) - Or try +=.. - Or just treat it as the buildfix and commit. Created attachment 46034 [details]
updated proposed patch
Attachment 46034 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/wtf/FastMalloc.cpp:3798: One space before end of line comments [whitespace/comments] [5]
Total errors found: 1
Created attachment 46035 [details]
proposed patch
style-queue ran check-webkit-style on attachment 46035 [details] without any errors.
Comment on attachment 46035 [details]
proposed patch
Okay. the += sizeof() should be equivalent to casting the address to the AllocAlignmentInteger* and then adding one (as done for new_ptr)...
Comment on attachment 46035 [details] proposed patch Clearing flags on attachment: 46035 Committed r52911: <http://trac.webkit.org/changeset/52911> All reviewed patches have been landed. Closing bug. Created attachment 46042 [details]
proposed patch for mac
Reopened because of Mac patch. style-queue ran check-webkit-style on attachment 46042 [details] without any errors.
I think the patch is wrong. It should be '+1' instead of the sizeof. Created attachment 46044 [details]
updated proposed patch for mac
Comment on attachment 46044 [details]
updated proposed patch for mac
Okay.
Committed r52918: <http://trac.webkit.org/changeset/52918> |