Bug 33312

Summary: [Qt] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot, zecke
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed patch
none
updated proposed patch
none
proposed patch
none
proposed patch for mac
none
updated proposed patch for mac zecke: review+

Zoltan Horvath
Reported 2010-01-07 01:38:10 PST
Change pByte to static_cast<AllocAlignmentInteger*>(old_ptr), because pByte (it was in an older patch and has not been updated) doesn't exist.
Attachments
proposed patch (1.23 KB, patch)
2010-01-07 01:40 PST, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
updated proposed patch (1.26 KB, patch)
2010-01-07 01:53 PST, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
proposed patch (1.19 KB, patch)
2010-01-07 02:02 PST, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
proposed patch for mac (1.32 KB, patch)
2010-01-07 03:49 PST, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
updated proposed patch for mac (1.29 KB, patch)
2010-01-07 04:01 PST, Zoltan Horvath 		zecke: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2010-01-07 01:40:21 PST
Created attachment 46032 [details] proposed patch
WebKit Review Bot
Comment 2 2010-01-07 01:44:42 PST
Attachment 46032 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/wtf/FastMalloc.cpp:3798: One space before end of line comments [whitespace/comments] [5] Total errors found: 1
Holger Freyther
Comment 3 2010-01-07 01:51:06 PST
The patch looks fine... some comments would be: - Refer to the commit that broke/added it. - You could use the same thing as with new_ptr (as in the original patch) - Or try +=.. - Or just treat it as the buildfix and commit.
Zoltan Horvath
Comment 4 2010-01-07 01:53:21 PST
Created attachment 46034 [details] updated proposed patch
WebKit Review Bot
Comment 5 2010-01-07 01:55:26 PST
Attachment 46034 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/wtf/FastMalloc.cpp:3798: One space before end of line comments [whitespace/comments] [5] Total errors found: 1
Zoltan Horvath
Comment 6 2010-01-07 02:02:00 PST
Created attachment 46035 [details] proposed patch
WebKit Review Bot
Comment 7 2010-01-07 02:05:52 PST
style-queue ran check-webkit-style on attachment 46035 [details] without any errors.
Holger Freyther
Comment 8 2010-01-07 02:16:35 PST
Comment on attachment 46035 [details] proposed patch Okay. the += sizeof() should be equivalent to casting the address to the AllocAlignmentInteger* and then adding one (as done for new_ptr)...
Zoltan Horvath
Comment 9 2010-01-07 02:19:54 PST
Comment on attachment 46035 [details] proposed patch Clearing flags on attachment: 46035 Committed r52911: <http://trac.webkit.org/changeset/52911>
Zoltan Horvath
Comment 10 2010-01-07 02:20:03 PST
All reviewed patches have been landed. Closing bug.
Zoltan Horvath
Comment 11 2010-01-07 03:49:45 PST
Created attachment 46042 [details] proposed patch for mac
Zoltan Horvath
Comment 12 2010-01-07 03:50:21 PST
Reopened because of Mac patch.
WebKit Review Bot
Comment 13 2010-01-07 03:54:34 PST
style-queue ran check-webkit-style on attachment 46042 [details] without any errors.
Holger Freyther
Comment 14 2010-01-07 03:55:44 PST
I think the patch is wrong. It should be '+1' instead of the sizeof.
Zoltan Horvath
Comment 15 2010-01-07 04:01:48 PST
Created attachment 46044 [details] updated proposed patch for mac
Holger Freyther
Comment 16 2010-01-07 04:03:35 PST
Comment on attachment 46044 [details] updated proposed patch for mac Okay.
Zoltan Horvath
Comment 17 2010-01-07 04:14:11 PST
Committed r52918: <http://trac.webkit.org/changeset/52918>
Note You need to log in before you can comment on or make changes to this bug.