Bug 33311

Summary: Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled
Product: WebKit Reporter: Gabor Loki <loki>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Blocker CC: barraclough, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled barraclough: review+

Gabor Loki
Reported 2010-01-07 01:23:10 PST
Created attachment 46030 [details] Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled When all optimizations are disabled for JSValue32 we have the following error: In function `JSC::JIT::emit_op_get_by_pname(JSC::Instruction*)': undefined reference to `JSC::JIT::compileGetDirectOffset(RegisterID, RegisterID, RegisterID, RegisterID, RegisterID)' The fix moves compileGetDirectOffset function to the common part of Value32.
Attachments
Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled (3.31 KB, patch)
2010-01-07 01:23 PST, Gabor Loki 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2010-01-07 01:23:43 PST
style-queue ran check-webkit-style on attachment 46030 [details] without any errors.
Gabor Loki
Comment 2 2010-01-07 23:43:00 PST
Committed revision 52975.
Note You need to log in before you can comment on or make changes to this bug.