Bug 33299

Summary:

[Gtk] FreeType backend does not respect FC_MATRIX property

Product:

WebKit

Reporter:

Dino Morelli <dino>

Component:

WebKitGTK

Assignee:

Martin Robinson <mrobinson>

Status:

RESOLVED FIXED

Severity:

Major

CC:

a.butenka, alex, dbates, dino, mrobinson

Priority:

Keywords:

PlatformOnly

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

36548

Bug Blocks:

46216

Attachments:

Description	Flags
sample HTML document illustrating CSS italic issue	none
Patch for this issue	cfleizach: review+

Dino Morelli

Reported 2010-01-06 21:05:33 PST

Created attachment 46018 [details] sample HTML document illustrating CSS italic issue Text that should display as italic is not rendering italic. Example HTML document attached. This is happening in both the Midori and uzbl browsers on Arch Linux 32-bit with libwebkit 1.1.15.4

Attachments
sample HTML document illustrating CSS italic issue (835 bytes, text/html) 2010-01-06 21:05 PST, Dino Morelli	no flags	Details
Patch for this issue (24.79 KB, patch) 2010-09-21 12:11 PDT, Martin Robinson	cfleizach: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dino Morelli

Comment 1 2010-01-06 21:17:03 PST

Versions of webkit browsers tested on the Arch Linux system: midori 0.2.2-1 uzbl-git 20091205-1

Martin Robinson

Comment 2 2010-09-17 15:35:19 PDT

The issue here seems to be that we are totally ignoring the FC_MATRIX property of the FcPattern we use to create the font.

Martin Robinson

Comment 3 2010-09-17 15:36:41 PDT

The FC_MATRIX property is *very* lightly documented, but we can observe it in Pango.

Martin Robinson

Comment 4 2010-09-21 12:11:29 PDT

Created attachment 68273 [details] Patch for this issue

Alexander Butenko

Comment 5 2010-09-28 10:08:58 PDT

ping?

Martin Robinson

Comment 6 2010-09-28 10:39:57 PDT

I'll see if I can find someone to review this today.

chris fleizach

Comment 7 2010-10-05 10:04:38 PDT

Comment on attachment 68273 [details] Patch for this issue View in context: https://bugs.webkit.org/attachment.cgi?id=68273&action=review r=me, but you should address the "new SimpleFontData" thing, even though its existing code > WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:89 > shouldn't this be adoptRef or something. Naked news are no longer in favor i believe.

Martin Robinson

Comment 8 2010-10-05 10:33:28 PDT

(In reply to comment #7) > shouldn't this be adoptRef or something. Naked news are no longer in favor i believe. Thanks for the review! I don't know if adoptRef is appropriate here because SimpleFontData isn't a descendant of RefCounted. In particular, it seems like m_smallCapsFontData is owned only by SimpleFontData.

Martin Robinson

Comment 9 2010-10-05 11:51:36 PDT

(In reply to comment #8) > Thanks for the review! I don't know if adoptRef is appropriate here because SimpleFontData isn't a descendant of RefCounted. In particular, it seems like m_smallCapsFontData is owned only by SimpleFontData. Chris, given this, do you still mind if I land the patch as-is?

Martin Robinson

Comment 10 2010-10-07 10:19:21 PDT

I'm almost 100% certain about the SimpleFontData issue, so I'll land as-is. If this is wrong though, we can roll it out ASAP.

Martin Robinson

Comment 11 2010-10-07 10:47:46 PDT

Committed r69320: <http://trac.webkit.org/changeset/69320>

Note You need to log in before you can comment on or make changes to this bug.