Summary: | SVGTextElement & friends need to implement svgAttributeChanged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||||
Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, krit, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Nikolas Zimmermann
2010-01-06 17:54:03 PST
Created attachment 46015 [details]
Initial patch
style-queue ran check-webkit-style on attachment 46015 [details] without any errors.
Comment on attachment 46015 [details]
Initial patch
An Enum instead of a Bool is always clearer:
42 static bool parseTransformAttribute(SVGTransformList*, const UChar*& ptr, const UChar* end, bool emptyList = true);
Created attachment 46051 [details]
Updated patch
Eric is right, fixed.
style-queue ran check-webkit-style on attachment 46051 [details] without any errors.
Comment on attachment 46051 [details]
Updated patch
LGTM. r=me
It was not clear to me that the test coverage was complete, which is why I was slow to review... well, that and I was incredibly tired when I looked at the bug. :) Thank you both. |