Bug 33284

Summary: SVGTextElement & friends need to implement svgAttributeChanged
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Severity: Normal CC: eric, krit, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Initial patch
Updated patch krit: review+

Description Nikolas Zimmermann 2010-01-06 17:54:03 PST
SVGTextElement & friends need to implement svgAttributeChanged. Dynamic updates of certain properties will fail at the moment. More info to come.
Comment 1 Nikolas Zimmermann 2010-01-06 19:26:47 PST
Created attachment 46015 [details]
Initial patch
Comment 2 WebKit Review Bot 2010-01-06 19:31:30 PST
style-queue ran check-webkit-style on attachment 46015 [details] without any errors.
Comment 3 Eric Seidel (no email) 2010-01-06 23:10:37 PST
Comment on attachment 46015 [details]
Initial patch

An Enum instead of a Bool is always clearer:
 42         static bool parseTransformAttribute(SVGTransformList*, const UChar*& ptr, const UChar* end, bool emptyList = true);
Comment 4 Nikolas Zimmermann 2010-01-07 07:24:16 PST
Created attachment 46051 [details]
Updated patch

Eric is right, fixed.
Comment 5 WebKit Review Bot 2010-01-07 07:26:37 PST
style-queue ran check-webkit-style on attachment 46051 [details] without any errors.
Comment 6 Dirk Schulze 2010-01-07 09:11:43 PST
Comment on attachment 46051 [details]
Updated patch

LGTM. r=me
Comment 7 Eric Seidel (no email) 2010-01-07 11:42:55 PST
It was not clear to me that the test coverage was complete, which is why I was slow to review... well, that and I was incredibly tired when I looked at the bug. :)  Thank you both.
Comment 8 Nikolas Zimmermann 2010-01-07 16:37:06 PST
Landed in r52960.