Bug 33284

Summary: SVGTextElement & friends need to implement svgAttributeChanged
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, krit, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Initial patch
none
Updated patch krit: review+

Nikolas Zimmermann
Reported 2010-01-06 17:54:03 PST
SVGTextElement & friends need to implement svgAttributeChanged. Dynamic updates of certain properties will fail at the moment. More info to come.
Attachments
Initial patch (21.55 KB, patch)
2010-01-06 19:26 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Updated patch (21.72 KB, patch)
2010-01-07 07:24 PST, Nikolas Zimmermann 		krit: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-01-06 19:26:47 PST
Created attachment 46015 [details] Initial patch
WebKit Review Bot
Comment 2 2010-01-06 19:31:30 PST
style-queue ran check-webkit-style on attachment 46015 [details] without any errors.
Eric Seidel (no email)
Comment 3 2010-01-06 23:10:37 PST
Comment on attachment 46015 [details] Initial patch An Enum instead of a Bool is always clearer: 42 static bool parseTransformAttribute(SVGTransformList*, const UChar*& ptr, const UChar* end, bool emptyList = true);
Nikolas Zimmermann
Comment 4 2010-01-07 07:24:16 PST
Created attachment 46051 [details] Updated patch Eric is right, fixed.
WebKit Review Bot
Comment 5 2010-01-07 07:26:37 PST
style-queue ran check-webkit-style on attachment 46051 [details] without any errors.
Dirk Schulze
Comment 6 2010-01-07 09:11:43 PST
Comment on attachment 46051 [details] Updated patch LGTM. r=me
Eric Seidel (no email)
Comment 7 2010-01-07 11:42:55 PST
It was not clear to me that the test coverage was complete, which is why I was slow to review... well, that and I was incredibly tired when I looked at the bug. :) Thank you both.
Nikolas Zimmermann
Comment 8 2010-01-07 16:37:06 PST
Landed in r52960.
Note You need to log in before you can comment on or make changes to this bug.