Summary: | We should reuse MediaControlTimeDisplayElement::formatTime function | ||
---|---|---|---|
Product: | WebKit | Reporter: | Chris Marrin <cmarrin> |
Component: | Media | Assignee: | Chris Marrin <cmarrin> |
Status: | RESOLVED CONFIGURATION CHANGED | ||
Severity: | Normal | CC: | ahmad.saleem792, eric.carlson, jer.noble |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | All | ||
OS: | All |
Description
Chris Marrin
2010-01-06 17:18:46 PST
This patch merged 'MediaControlTimeDisplayElement' into 'MediaControlElementTypes.cpp'. https://github.com/WebKit/WebKit/commit/f9e9a9581511ef57234ffbd25cd6a7532123b54e and this commit also deleted above file: https://github.com/WebKit/WebKit/commit/e3e80694948e94e81d10faf2c0da5fb213ece5e8 Plus no function with '::formatTime' exist as per quick search. I don't think this 2010 old bug would add much value and if needed any refactoring, it can be done in new bug. I am marking this as 'RESOLVED CONFIGURATION CHANGED' but will CC - Eric and Jer for any input. |