Bug 33246
| Summary: | webkit-patch land should warn when changelog doesn't match committer | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | abarth, eric |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Ojan Vafai
I just had the following happen:
1. git svn rebase successfully merged my ChangeLog file, but didn't put my entry at the top
2. bugzilla-tool land-diff committed my change with the wrong commit message
See http://trac.webkit.org/changeset/52844
Technically, I should have noticed in the diff that the ChangeLog entry wasn't at the top, but it would be nice to be a bit more idiot-proof. Can land-diff confirm that you want to commit if the email address doesn't match git's configured email address? Obviously, this would always be true on the commit bot, but for human beings committing, I think this is by far the common case (i.e. that they're committing their own patches).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
We have like 8 dupes of this bug on file. Git users run into this kind of thing all the time. :(
Eric Seidel (no email)
*** This bug has been marked as a duplicate of bug 28092 ***