Summary: | [v8] Move V8DOMWindowShell to ScriptController | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED INVALID | ||||||
Severity: | Normal | CC: | dglazkov, kbalazs, pkasting, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Adam Barth
2010-01-05 15:04:33 PST
Created attachment 45934 [details]
Patch
I tried to keep this one small... Not sure I succeeded. style-queue ran check-webkit-style on attachment 45934 [details] without any errors.
Comment on attachment 45934 [details] Patch Rocking! > + ~V8DOMWindowShell(); virtual? > + // FIXME: I be we can clean this up a bit! We be cleanin' :D Comment on attachment 45934 [details]
Patch
Waiting for the kr build to unbust before landing.
Committed r52847: <http://trac.webkit.org/changeset/52847> Reverted r52847 for reason: Might have caused a perf regression. Committed r52937: <http://trac.webkit.org/changeset/52937> Committed r52938: <http://trac.webkit.org/changeset/52938> Reopening, since the patch was backed out. Comment on attachment 45934 [details]
Patch
Clearing flags on patch that was backed out.
Closing some V8-related work items. |