Bug 33232

Summary: [v8] Move V8DOMWindowShell to ScriptController
Product: WebKit Reporter: Adam Barth <abarth>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: dglazkov, kbalazs, pkasting, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2010-01-05 15:04:33 PST
[v8] Move V8DOMWindowShell to ScriptController
Attachments
Patch (20.66 KB, patch)
2010-01-05 15:07 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-01-05 15:07:11 PST
Created attachment 45934 [details] Patch
Adam Barth
Comment 2 2010-01-05 15:07:31 PST
I tried to keep this one small... Not sure I succeeded.
WebKit Review Bot
Comment 3 2010-01-05 15:10:18 PST
style-queue ran check-webkit-style on attachment 45934 [details] without any errors.
Dimitri Glazkov (Google)
Comment 4 2010-01-05 16:35:48 PST
Comment on attachment 45934 [details] Patch Rocking! > + ~V8DOMWindowShell(); virtual? > + // FIXME: I be we can clean this up a bit! We be cleanin' :D
Adam Barth
Comment 5 2010-01-05 17:39:06 PST
Comment on attachment 45934 [details] Patch Waiting for the kr build to unbust before landing.
Adam Barth
Comment 6 2010-01-05 19:09:34 PST
Committed r52847: <http://trac.webkit.org/changeset/52847>
Adam Barth
Comment 7 2010-01-07 12:01:15 PST
Reverted r52847 for reason: Might have caused a perf regression. Committed r52937: <http://trac.webkit.org/changeset/52937>
Adam Barth
Comment 8 2010-01-07 12:08:27 PST
Committed r52938: <http://trac.webkit.org/changeset/52938>
Peter Kasting
Comment 9 2010-01-07 18:42:45 PST
Reopening, since the patch was backed out.
Peter Kasting
Comment 10 2010-01-07 18:43:11 PST
Comment on attachment 45934 [details] Patch Clearing flags on patch that was backed out.
Brian Burg
Comment 11 2014-12-16 00:48:26 PST
Closing some V8-related work items.
Note You need to log in before you can comment on or make changes to this bug.