Bug 33219

Summary: Add assertions to catch double-destruction of WebViews earlier
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Patch darin: review+

Description Adam Roben (:aroben) 2010-01-05 10:46:28 PST
Created attachment 45909 [details]
Patch

I basically copied the m_deletionHasBegun logic from WTF::RefCounted.

Need a short description and bug URL (OOPS!)

Reviewed by NOBODY (OOPS!).

* WebView.cpp:
(WebView::WebView): Initialize m_deletionHasBegun
(WebView::AddRef): Assert that deletion hasn't already begun.
(WebView::Release): Assert that deletion hasn't already begun, then
record when deletion *does* begin.

* WebView.h: Added m_deletionHasBegun.
---
 3 files changed, 32 insertions(+), 1 deletions(-)
Comment 1 Adam Roben (:aroben) 2010-01-05 15:09:24 PST
Committed r52828: <http://trac.webkit.org/changeset/52828>