WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
33219
Add assertions to catch double-destruction of WebViews earlier
https://bugs.webkit.org/show_bug.cgi?id=33219
Summary
Add assertions to catch double-destruction of WebViews earlier
Adam Roben (:aroben)
Reported
2010-01-05 10:46:28 PST
Created
attachment 45909
[details]
Patch I basically copied the m_deletionHasBegun logic from WTF::RefCounted. Need a short description and bug URL (OOPS!) Reviewed by NOBODY (OOPS!). * WebView.cpp: (WebView::WebView): Initialize m_deletionHasBegun (WebView::AddRef): Assert that deletion hasn't already begun. (WebView::Release): Assert that deletion hasn't already begun, then record when deletion *does* begin. * WebView.h: Added m_deletionHasBegun. --- 3 files changed, 32 insertions(+), 1 deletions(-)
Attachments
Patch
(2.18 KB, patch)
2010-01-05 10:46 PST
,
Adam Roben (:aroben)
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1
2010-01-05 15:09:24 PST
Committed
r52828
: <
http://trac.webkit.org/changeset/52828
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug