Bug 33219 - Add assertions to catch double-destruction of WebViews earlier
Summary: Add assertions to catch double-destruction of WebViews earlier
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-05 10:46 PST by Adam Roben (:aroben)
Modified: 2010-01-05 15:09 PST (History)
1 user (show)

See Also:

Attachments
Patch (2.18 KB, patch)
2010-01-05 10:46 PST, Adam Roben (:aroben) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-01-05 10:46:28 PST 
Created attachment 45909 [details]
Patch

I basically copied the m_deletionHasBegun logic from WTF::RefCounted.

Need a short description and bug URL (OOPS!)

Reviewed by NOBODY (OOPS!).

* WebView.cpp:
(WebView::WebView): Initialize m_deletionHasBegun
(WebView::AddRef): Assert that deletion hasn't already begun.
(WebView::Release): Assert that deletion hasn't already begun, then
record when deletion *does* begin.

* WebView.h: Added m_deletionHasBegun.
---
 3 files changed, 32 insertions(+), 1 deletions(-)
Comment 1 Adam Roben (:aroben) 2010-01-05 15:09:24 PST 
Committed r52828: <http://trac.webkit.org/changeset/52828>