| Summary: | Add more WebViewDestruction tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | sam, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Attachments: |
|
||||||
style-queue ran check-webkit-style on attachment 45907 [details] without any errors.
Comment on attachment 45907 [details] Patch LGTM. Needs a bug link. prepare-ChangeLog --bug 12355 will do that for you. bugzilla-tool submit-patch will also create the bug and update the ChangeLogs for you if that's easier in the future. Committed r52826: <http://trac.webkit.org/changeset/52826> |
Created attachment 45907 [details] Patch Need a short description and bug URL (OOPS!) Reviewed by NOBODY (OOPS!). * WebKitAPITest/tests/WebViewDestruction.cpp: (WebKitAPITest::NoInitWithFrame): (WebKitAPITest::CloseThenDestroyViewWindow): (WebKitAPITest::DestroyViewWindowThenClose): (WebKitAPITest::DestroyHostWindow): (WebKitAPITest::DestroyHostWindowThenClose): (WebKitAPITest::CloseThenDestroyHostWindow): Added these tests that exercise tearing down a WebView in various ways, all of which we eventually want to have work. Some of them currently crash or leak. --- 2 files changed, 110 insertions(+), 6 deletions(-)